[PATCH] D81341: [LLVM-C] Add C API for removing global

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

You can ignore the build failure; the infrastructure for pre-commit testing is new, and it looks like it failed spuriously.

If you're not using arcanist, please upload patches with full context (-U10000).

C APIs should have appropriate documentation.  Some of the existing APIs are missing documentation, but please ensure new ones are properly documented.

How are you actually planning to use this API?  As far as I can tell, given the other existing APIs, the GlobalVariable is guaranteed to leak.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81341/new/

https://reviews.llvm.org/D81341