[PATCH] D81369: [Alignment][NFC] Migrate AtomicExpandPass to Align

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 8 14:25:12 PDT 2020


efriedma added a comment.

> I'm unsure about getAtomicOpAlign overloads that take AtomicRMWInst and AtomicCmpXchgInst, shouldn't getAlign provide the correct answer already?

getAlign() on what?  AtomicRMWInst and AtomicCmpXchgInst don't have a getAlign() method.  (It might make sense to add.)



================
Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:1536
   unsigned Size = getAtomicOpSize(I);
-  unsigned Align = getAtomicOpAlign(I);
+  Align Alignment = getAtomicOpAlign(I);
 
----------------
Can just use I->getAlign() here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81369/new/

https://reviews.llvm.org/D81369





More information about the llvm-commits mailing list