[PATCH] D75866: [AIX] supporting the visibility attribute for aix assembly

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 8 13:52:11 PDT 2020


hubert.reinterpretcast accepted this revision.
hubert.reinterpretcast added a comment.

LGTM with small comment.



================
Comment at: llvm/lib/MC/MCAsmInfoXCOFF.cpp:19
   PrivateLabelPrefix = "L..";
+  HasVisibilityOnlyWithLinkage = true;
   SupportsQuotedNames = false;
----------------
hubert.reinterpretcast wrote:
> Move this to right after `IsLittleEndian` to maintain matching the base class order.
? I said to move `HasVisibilityOnlyWithLinkage` up, not `IsLittleEndian` down.

```
  IsLittleEndian = false;
  HasVisibilityOnlyWithLinkage = true;
  PrivateGlobalPrefix = "L..";
  PrivateLabelPrefix = "L..";
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75866/new/

https://reviews.llvm.org/D75866





More information about the llvm-commits mailing list