[PATCH] D81381: GlobalISel: Move some trivial MIRBuilder methods into the header

Mon Jun 8 12:08:24 PDT 2020

arsenm added a comment.

In D81381#2080450 <https://reviews.llvm.org/D81381#2080450>, @aditya_nandakumar wrote:

> > The construction APIs for MachineIRBuilder don't make much sense,
>
> What exactly do you mean by this? I agree with the latter about these trivial methods getting in the way.

See D81382 <https://reviews.llvm.org/D81382>. I also think it's a problem that RegBankSelect and other backend users need to construct their own single purpose builders, when the builder is supposed to be maintaining CSE state for example

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81381/new/

https://reviews.llvm.org/D81381