[PATCH] D81410: [ELF][AArch64] Correct relocation codes for R_<CLS>_PLT32

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 8 11:02:49 PDT 2020


pcc added inline comments.


================
Comment at: llvm/include/llvm/BinaryFormat/ELFRelocs/AArch64.def:123
 ELF_RELOC(R_AARCH64_TLSLD_LDST128_DTPREL_LO12_NC,    0x23d)
+ELF_RELOC(R_AARCH64_PLT32,                           0x23e)
+// Dynamic relocations start
----------------
Shouldn't it be in the range `[0x100..0x200)`? This value is in the range used for TLS relocations, `[0x200..0x300)`.


================
Comment at: llvm/include/llvm/BinaryFormat/ELFRelocs/AArch64.def:215
 ELF_RELOC(R_AARCH64_P32_TLSDESC_CALL,                0x07f)
+ELF_RELOC(R_AARCH64_P32_PLT32,                       0x080)
+// Dynamic relocations start
----------------
Likewise. It looks like `[0x00..0x50)` is the range for the aarch64_32 non-TLS relocations.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81410/new/

https://reviews.llvm.org/D81410





More information about the llvm-commits mailing list