[PATCH] D80885: [VectorCombine] scalarizeBinop - support an all-constant src vector operand

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 8 10:30:18 PDT 2020


lebedev.ri accepted this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.

SGTM, but please wait for @spatel.



================
Comment at: llvm/lib/Transforms/Vectorize/VectorCombine.cpp:385
+  if (!V0) {
+    V0 = Builder.CreateExtractElement(VecC0, Index);
+    if (!isa_and_nonnull<Constant>(V0))
----------------
lebedev.ri wrote:
> `ConstantExpr::getExtractElement()` ?
not done


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80885/new/

https://reviews.llvm.org/D80885





More information about the llvm-commits mailing list