[PATCH] D80824: [CodeGen][SVE] Avoid scalarizing zero splat stores on scalable vectors.

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 8 10:30:18 PDT 2020


sdesmalen accepted this revision.
sdesmalen added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:11973
+  // Avoid scalarizing zero splat stores for scalable vectors.
+  if (VT.isScalableVector() || !VT.isFixedLengthVector())
+    return SDValue();
----------------
I think you can remove the condition `|| !VT.isFixedLengthVector()`, because this function would otherwise break if it isn't.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80824/new/

https://reviews.llvm.org/D80824





More information about the llvm-commits mailing list