[PATCH] D80591: Patch up pthread issues with GN build

Mitch Phillips via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 8 09:56:49 PDT 2020


hctim updated this revision to Diff 269270.
hctim added a comment.

- Rebase against master now that the library link order is fixed by D81035 <https://reviews.llvm.org/D81035>.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80591/new/

https://reviews.llvm.org/D80591

Files:
  llvm/utils/gn/build/libs/pthread/BUILD.gn


Index: llvm/utils/gn/build/libs/pthread/BUILD.gn
===================================================================
--- llvm/utils/gn/build/libs/pthread/BUILD.gn
+++ llvm/utils/gn/build/libs/pthread/BUILD.gn
@@ -2,12 +2,11 @@
 
 config("pthread_config") {
   visibility = [ ":pthread" ]
-  libs = [ "pthread" ]
+  ldflags = [ "-pthread" ]
 }
 
 group("pthread") {
-  # On Android, bionic has built-in support for pthreads.
-  if (llvm_enable_threads && current_os != "win" && current_os != "android") {
-    public_configs = [ ":pthread_config" ]
+  if (llvm_enable_threads && current_os != "win") {
+    all_dependent_configs = [ ":pthread_config" ]
   }
 }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D80591.269270.patch
Type: text/x-patch
Size: 660 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200608/577efc30/attachment.bin>


More information about the llvm-commits mailing list