[PATCH] D80866: [cmake] Allow llvm_ExternalProject_Add to find CMAKE_SYSTEM_NAME among ${proj}_CMAKE_ARGS

Saleem Abdulrasool via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 8 09:56:48 PDT 2020


compnerd added a comment.

Hmm, this tries to extract `CMAKE_SYSTEM_NAME` from `..._CMAKE_ARGS` if Im reading this correctly.  Why not just say that you must pass `CMAKE_SYSTEM_NAME` via `..._CMAKE_ARGS` rather than `CMAKE_ARGS` and just drop the clause above it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80866/new/

https://reviews.llvm.org/D80866





More information about the llvm-commits mailing list