[PATCH] D81357: [DWARFYAML][debug_ranges] Emit an error message for invalid offset.

Xing GUO via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 8 08:11:20 PDT 2020


Higuoxing added inline comments.


================
Comment at: llvm/test/tools/yaml2obj/ELF/DWARF/debug-ranges.yaml:337
+          HighOffset: 0x02
+    - Offset:   0x10 ## Must be greater than or equal to 0x20.
+      AddrSize: 0x08
----------------
jhenderson wrote:
> jhenderson wrote:
> > Let's make this `0x1A` to test the edge case (i.e. no off-by-one error).
> Oops, sorry, I failed at hex :-)
> 
> I meant 0x1f, i.e. exactly one less than the permitted value!
Never mind :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81357/new/

https://reviews.llvm.org/D81357





More information about the llvm-commits mailing list