[PATCH] D81387: GlobalISel: Set instr/debugloc before any legalizer action

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 8 07:05:25 PDT 2020


arsenm created this revision.
arsenm added reviewers: dsanders, paquette, aditya_nandakumar, aemerson.
Herald added subscribers: kerbowa, atanasyan, hiraditya, tpr, aprantl, rovka, nhaehnle, wdng, jvesely, sdardis.
Herald added a project: LLVM.

It was annoying enough that every custom lowering needed to set the
insert point, but this was made worse since now these all needed to be
updated to setInstrAndDebugLoc. Consolidate these so every
legalization action has the right insert position by default.

      

This should fix dropping debug info in every custom AMDGPU
legalization.


https://reviews.llvm.org/D81387

Files:
  llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
  llvm/lib/Target/AArch64/GISel/AArch64LegalizerInfo.cpp
  llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp
  llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp
  llvm/lib/Target/Mips/MipsLegalizerInfo.cpp
  llvm/unittests/CodeGen/GlobalISel/LegalizerHelperTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D81387.269203.patch
Type: text/x-patch
Size: 25111 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200608/39d7ed1c/attachment.bin>


More information about the llvm-commits mailing list