[PATCH] D80888: AMDGPU/GlobalISel: Make G_IMPLICIT_DEF legality more consistent

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 8 06:31:07 PDT 2020


arsenm marked an inline comment as done.
arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-fdiv.mir:215
     ; SI: [[FNEG:%[0-9]+]]:_(s32) = G_FNEG [[INT]]
-    ; SI: S_SETREG_IMM32_B32 3, 2305
+    ; SI: S_SETREG_IMM32_B32 3, 2305, implicit-def $mode, implicit $mode
     ; SI: [[FMA:%[0-9]+]]:_(s32) = G_FMA [[FNEG]], [[INT4]], [[C]]
----------------
foad wrote:
> All these changes are unrelated.
One of the issues with update_*test_checks scripts is they don't match the end of the line, so they miss new additions at the end. I can precommit a no-op regenerate these


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80888/new/

https://reviews.llvm.org/D80888





More information about the llvm-commits mailing list