[PATCH] D80797: [DebugInfo] Check for errors when reading data for extended opcode

Pavel Labath via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 8 04:19:48 PDT 2020


labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

Looks good to me.



================
Comment at: llvm/unittests/DebugInfo/DWARF/DWARFDebugLineTest.cpp:1330-1331
+    StringRef OutputRef(Output);
+    StringRef OutputToCheck =
+        OutputRef.substr(OutputRef.find(LinePrefix) + LinePrefix.size());
+    EXPECT_EQ((ExpectedOutput + "\n").str(), OutputToCheck);
----------------
Maybe `OutputRef.split(LinePrefix).second`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80797/new/

https://reviews.llvm.org/D80797





More information about the llvm-commits mailing list