[PATCH] D79936: [FileCheck] Add function call support to numerical expressions.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.

Tip to help reviewers: click the "Done" box on inline comments before uploading a patch to indicate you have addressed a specific comment. The comment will then be marked as Done when you upload the next diff.

LGTM, thanks, but wait for others.



================
Comment at: llvm/lib/Support/FileCheck.cpp:350
 
+  for (unsigned E = Str.size(); I != E; ++I)
     // Variable names are composed of alphanumeric characters and underscores.
----------------
I know this was here before, but since you are modifying this line, you can fix on the way (or in a separate commit before if you prefer): use `size_t` rather than `unsigned` to match the return type of `Str.size()`. Optionally also update `I` to `size_t` for the same reason.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79936/new/

https://reviews.llvm.org/D79936