[PATCH] D81147: [MC] Generate .debug_rnglists in the 64-bit DWARF format [5/7]

Mon Jun 8 00:30:07 PDT 2020

jhenderson accepted this revision.
jhenderson added a comment.

LGTM again.

================
Comment at: llvm/test/MC/ELF/gen-dwarf64.s:31
 # DUMP:       .debug_aranges contents:
-# DUMP-NEXT:  Address Range Header: length = 0x0000000000000034, format = DWARF64, version = 0x0002, cu_offset = 0x0000000000000000, addr_size = 0x08, seg_size = 0x00
+# DUMP-NEXT:  Address Range Header: length = 0x0000000000000044, format = DWARF64, version = 0x0002, cu_offset = 0x0000000000000000, addr_size = 0x08, seg_size = 0x00
+# DUMP-NEXT:  [0x0000000000000000,  0x0000000000000001)
----------------
Up to you, but you could probably simplify this line, by deleting everything after `format = DWARF64`

================
Comment at: llvm/test/MC/ELF/gen-dwarf64.s:51
+# DUMP5:      .debug_rnglists contents:
+# DUMP5-NEXT: 0x00000000: range list header: length = 0x000000000000001d, format = DWARF64, version = 0x0005, addr_size = 0x08, seg_size = 0x00, offset_entry_count = 0x00000000
+# DUMP5-NEXT: ranges:
----------------
Same comment as above.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81147/new/

https://reviews.llvm.org/D81147