[PATCH] D78669: PowerPC: Add emergency stack spill slots for SPE

Justin Hibbits via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 6 20:48:59 PDT 2020


jhibbits marked 2 inline comments as done.
jhibbits added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/spe-spills.ll:7
+
+ at d = local_unnamed_addr global double* null, align 4
+ at c = local_unnamed_addr global i32 0, align 4
----------------
jhibbits wrote:
> sfertile wrote:
> > Is it possible to handwrite a simple test to expose the issue? If its too difficult we can stick with this test but I think something simpler which showcases the problem would be ideal.
> I'll see if I can reduce it to something simple.  This is actually the post-creduce result that exhibited the issue, any more reduction and it doesn't seem to trip it.
This is really odd, I am unable to reproduce the failure now, even rolling back to origin/release/10.x.  The change needed is obviously correct, but being unable to test it is a problem.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78669/new/

https://reviews.llvm.org/D78669





More information about the llvm-commits mailing list