[PATCH] D79936: [FileCheck] Add function call support to numerical expressions.

Paul Walker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 6 03:10:20 PDT 2020


paulwalker-arm updated this revision to Diff 269003.
paulwalker-arm added a comment.

I initially misread the "max + max" related comments and went down the wrong path.  Happily it was not in vain as it prompted me to reuse parseVariable because the function relates to identifiers rather than just variables.  I've also simplied parseVariable a little but stopped short of renaming things.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79936/new/

https://reviews.llvm.org/D79936

Files:
  llvm/docs/CommandGuide/FileCheck.rst
  llvm/lib/Support/FileCheck.cpp
  llvm/lib/Support/FileCheckImpl.h
  llvm/test/FileCheck/numeric-expression.txt
  llvm/unittests/Support/FileCheckTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D79936.269003.patch
Type: text/x-patch
Size: 23505 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200606/7868b00c/attachment-0001.bin>


More information about the llvm-commits mailing list