[PATCH] D77647: [ELF][AArch64] Add R_AARCH64_PLT32 relocation type.

Fri Jun 5 18:59:41 PDT 2020

pcc added inline comments.

================
Comment at: llvm/include/llvm/BinaryFormat/ELFRelocs/AArch64.def:135
 ELF_RELOC(R_AARCH64_IRELATIVE,                       0x408)
+ELF_RELOC(R_AARCH64_PLT32,                           0x409)

----------------
mcgrathr wrote:
> pcc wrote:
> > I assume this isn't the final value of the relocation type? The range `[0x400, ...]` is reserved for dynamic relocations; I would have expected this to be added in the range `[0x100, 0x200)` together with the other non-TLS static relocations.
> The draft shared by peter.smith at arm.com says:
> ```
> +    | ELF64 Code | ELF32 Code | Name              | Operation | Comment                                                                   |
> +    | 1033       | 189        | R\_<CLS>\_PLT32   | S + A - P | Check that -2\ :sup:`31` <= X < 2\ :sup:`31` see call and jump relocations|
> ```
> I don't think it has been finalized yet so if different values make more sense, please follow up with him and/or arm.eabi at arm.com where these additions were discussed (and please CC: me and @leonardchan on any such discussion).
Thanks, I followed up on the arm.eabi thread that everyone should already be cc'd on.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77647/new/

https://reviews.llvm.org/D77647