[PATCH] D81260: [AMDGPU][NFC] Skip processing intrinsics that do not become real instructions

Daniil Fukalov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 5 17:55:53 PDT 2020


dfukalov marked 2 inline comments as done.
dfukalov added a comment.

Possible I should re-create the review - diffs are displayed like a mess after updates



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULibCalls.cpp:1729
   for (auto &BB : F) {
     for (BasicBlock::iterator I = BB.begin(), E = BB.end(); I != E; ) {
       // Ignore non-calls.
----------------
arsenm wrote:
> Can also use instructionsWithoutDebug iterator instead
We cannot use simple range iterator here since BB can be modified in the loop


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81260/new/

https://reviews.llvm.org/D81260





More information about the llvm-commits mailing list