[PATCH] D81269: Fix null pointer dereference in `ProfileSummaryInfo::getPSI()`

Pietro Fezzardi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 5 16:50:11 PDT 2020


fez added a comment.

In D81269#2077113 <https://reviews.llvm.org/D81269#2077113>, @davidxl wrote:

> Can you revert D54669 <https://reviews.llvm.org/D54669> and remove the pointer to reference change and recommit?


Right now it does not revert cleanly.

And according to the additional discussion that I posted above it might not be necessary to revert the change after all, given that the crash is only triggered by someone misusing the API, forgetting to call `doInitialize` before `run`.

Anyway, I'll wait to hear what @vsk has to say, and if we decide to go on with the fix (or some variants of it), I will revert the D54669 <https://reviews.llvm.org/D54669>, erase the offending parts from the cosmetic change, and recommit it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81269/new/

https://reviews.llvm.org/D81269





More information about the llvm-commits mailing list