[PATCH] D81185: [ELF] Adding accessor method for getting Note Desc as StringRef

Scott Linder via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 5 11:12:57 PDT 2020


scott.linder accepted this revision.
scott.linder added a comment.
This revision is now accepted and ready to land.

I don't know why I didn't add any tests of `getDesc()` (or anything else) originally, maybe because there is no existing testing and it requires both a unit test and a binary file input? I think at this point we shouldn't block adding an obvious 1-line function on adding tests that should already exist. So, LGTM with Matt's request addressed, and we can add testing in a general way at some point.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81185/new/

https://reviews.llvm.org/D81185





More information about the llvm-commits mailing list