[PATCH] D81033: [PowerPC] Fix incorrect PC Relative relocations for Big Endian

Sean Fertile via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 5 10:36:05 PDT 2020


sfertile accepted this revision as: sfertile.
sfertile added a comment.

LGTM.

Minor nit not related to this patch is that the test is really noisy. I realize this is the assembly clang emits, but a lit test can be cleaned up to just the needed constructs. Removing the comments, zero padding after the functions,  local aliases (`.Lexternal$local`) and finally the size directives and the labels that are only needed for those directives  goes along way in creating a much simpler test that helps to highlight exactly what functionality is being exercised at a glance. After landing this patch can you do an NFC cleanup of the test?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81033/new/

https://reviews.llvm.org/D81033





More information about the llvm-commits mailing list