[PATCH] D80703: [FileCheck][unittest] Use parameterized unittests

Thomas Preud'homme via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 5 05:28:10 PDT 2020


thopre abandoned this revision.
thopre added a comment.

In D80703#2062854 <https://reviews.llvm.org/D80703#2062854>, @jhenderson wrote:

> Thanks for looking at this. This hasn't quite collapsed the code in the way that I imagined it would, so I'm happy for this idea to be abandoned if you don't think it is worthwhile. Otherwise, I'll take a look next week.


It could probably be quite shorter if there was a way to keep some parameter templated in the fixture (namely the distinction between signed and unsigned values). Unfortunately I had errors when I tried that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80703/new/

https://reviews.llvm.org/D80703





More information about the llvm-commits mailing list