[PATCH] D81207: [VE] Support fixed-point operation instructions in MC layer

[Simon Moll via Phabricator via llvm-commits]

simoll added a comment.

Nits. Otw, LGTM. Thx!



================
Comment at: llvm/lib/Target/VE/AsmParser/VEAsmParser.cpp:366
+    assert(N == 1 && "Invalid number of operands!");
+    const MCConstantExpr *ConstExpr = dyn_cast<MCConstantExpr>(getMImmVal());
+    assert(ConstExpr && "Null operands!");
----------------
[optional] You could use a `const auto*` here


================
Comment at: llvm/lib/Target/VE/AsmParser/VEAsmParser.cpp:707
+OperandMatchResultTy VEAsmParser::parseMImmOperand(OperandVector &Operands) {
+  LLVM_DEBUG(dbgs() << "parseMImmOpeand\n");
+
----------------
typo


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81207/new/

https://reviews.llvm.org/D81207