[PATCH] D81149: [MC] Generate .debug_frame in the 64-bit DWARF format [7/7]

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 5 01:03:47 PDT 2020


jhenderson added inline comments.


================
Comment at: llvm/lib/MC/MCDwarf.cpp:1760-1766
+    emitAbsValue(Streamer, offset, OffsetSize);
   } else if (!asmInfo->doesDwarfUseRelocationsAcrossSections()) {
     const MCExpr *offset =
         MakeStartMinusEndExpr(context, SectionStart, cieStart, 0);
-    emitAbsValue(Streamer, offset, 4);
+    emitAbsValue(Streamer, offset, OffsetSize);
   } else {
+    Streamer.emitSymbolValue(&cieStart, OffsetSize,
----------------
There are three cases here that have been modified, but I don't see three test cases?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81149/new/

https://reviews.llvm.org/D81149





More information about the llvm-commits mailing list