[PATCH] D80838: [llvm-ar] Add more tests for errors in opening archives

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 5 00:30:38 PDT 2020


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with one suggestion.



================
Comment at: llvm/test/tools/llvm-ar/error-opening-permission.test:2
+## Unsupported on windows as marking files "unreadable"
+## is non-trivial with chmod on windows.
+# UNSUPPORTED: system-windows
----------------
I'd delete the "with chmod" bit of this comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80838/new/

https://reviews.llvm.org/D80838





More information about the llvm-commits mailing list