[PATCH] D81144: [MC] Generate .debug_line in the 64-bit DWARF format [2/7]

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 4 23:06:25 PDT 2020


dblaikie added a comment.

In D81144#2075404 <https://reviews.llvm.org/D81144#2075404>, @ikudrin wrote:

> In D81144#2075322 <https://reviews.llvm.org/D81144#2075322>, @MaskRay wrote:
>
> > If the linker places huge_c.o:.text before asm.o:.text, it would be weird if the linker places asm.o:.debug_info before huge_c.o:.debug_info
> >  A linker can be smarter, but the output will be unexpected.
>
>
> That might be unexpected, but in some cases that might be the only way to make the output at all. I have not dug that deep, but probably the order of some debug info sections might be adjusted without violating the correctness of the information, no?


Yep. Though I don't think we need to invoke that possibility to justify the support for DWARF64 for assembler source - as you point out, sec offsets may need to be 64 bit even if all contributions are small - if the overall section is large.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81144/new/

https://reviews.llvm.org/D81144





More information about the llvm-commits mailing list