[PATCH] D81144: [MC] Generate .debug_line in the 64-bit DWARF format [2/7]

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In D81144#2075184 <https://reviews.llvm.org/D81144#2075184>, @ikudrin wrote:

> I can agree that `DWARF64` is not needed for individual files, especially assembly files. They hardly can exceed `DWARF32` limitations. But object files are just intermediate, later they are combined to a larger executable binary, and, if that binary is large enough, we can hit the `DWARF32` limits. Converting debugging info at the linker stage does not seem to be an easy task, thus, the info should be prepared in an appropriate form from the beginning.


Yeah, though you don't have to have all your DWARF in DWARF64 - you could have the assembly CU in DWARF32 and other CUs/files in DWARF64 - but I still think it's nice to implement it everywhere for consistency/easier to test, support flags (if you turn on DWARF64 for your build it'd be weird/annoying if it worked for some things and not others), etc. Maybe someone creates a huge machine-generated assembly file that would still benefit from assembly-level debug info, etc.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81144/new/

https://reviews.llvm.org/D81144