[PATCH] D80962: [NativeSession] Implement findLineNumbersByAddress functions for native llvm-symbolizer support.

Amy Huang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 4 17:09:24 PDT 2020


akhuang updated this revision to Diff 268627.
akhuang marked 5 inline comments as done.
akhuang added a comment.
Herald added a subscriber: mgrang.

Address comments.

I also changed the line table construction so that modules are added to the line
table as they are needed (instead of adding all at the beginning), since in practice
only a small number of lines are queried for.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80962/new/

https://reviews.llvm.org/D80962

Files:
  llvm/include/llvm/DebugInfo/PDB/Native/NativeEnumLineNumbers.h
  llvm/include/llvm/DebugInfo/PDB/Native/NativeLineNumber.h
  llvm/include/llvm/DebugInfo/PDB/Native/NativeSourceFile.h
  llvm/include/llvm/DebugInfo/PDB/Native/SymbolCache.h
  llvm/lib/DebugInfo/PDB/CMakeLists.txt
  llvm/lib/DebugInfo/PDB/Native/NativeEnumLineNumbers.cpp
  llvm/lib/DebugInfo/PDB/Native/NativeLineNumber.cpp
  llvm/lib/DebugInfo/PDB/Native/NativeSession.cpp
  llvm/lib/DebugInfo/PDB/Native/NativeSourceFile.cpp
  llvm/lib/DebugInfo/PDB/Native/SymbolCache.cpp
  llvm/lib/DebugInfo/PDB/PDB.cpp
  llvm/test/tools/llvm-symbolizer/pdb/pdb-native.test
  llvm/utils/gn/secondary/llvm/lib/DebugInfo/PDB/BUILD.gn

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D80962.268627.patch
Type: text/x-patch
Size: 30438 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200605/2e9c382d/attachment.bin>


More information about the llvm-commits mailing list