[PATCH] D78203: [VP,Integer,#2] ExpandVectorPredication pass

[Craig Topper via Phabricator via llvm-commits]

craig.topper added a comment.

There are still more "auto" variables that are pointers in this patch.



================
Comment at: llvm/include/llvm/IR/PredicatedInst.h:34
+
+class PredicatedInstruction : public User {
+public:
----------------
simoll wrote:
> craig.topper wrote:
> > Can this inherit from Instruction? Its a little surprising that it has Instruction in its name but has to be casted to Instruction.
> Conceptually, `PredicatedInstruction` is a super class of `Instruction`: An `Instruction` is a `PredicatedInstruction` with the mask/evl parameters hard-wired to "all lanes true". That's why we can't make Instruction an ancestor of this one.
> I'll clarify this with a comment.
But a VPIntrinsic is also an Instruction isn't it? At least the CallInst for the vp intrinsic is an Instruction.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78203/new/

https://reviews.llvm.org/D78203