[PATCH] D81175: Add ASan metadata globals to @llvm.compiler.used under COFF

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 4 12:42:55 PDT 2020


aeubanks added a comment.

In D81175#2074382 <https://reviews.llvm.org/D81175#2074382>, @hans wrote:

> In D81175#2074045 <https://reviews.llvm.org/D81175#2074045>, @aeubanks wrote:
>
> > As for tests, I think making these work under the NPM, which we hopefully switch to soon, counts as tests.
>
>
> Adding checks for @llvm.compiler.used in llvm/test/Instrumentation/AddressSanitizer/global_metadata_windows.ll would probably be good too.


Ah I didn't see those tests, I forgot that the instrumentation itself has tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81175/new/

https://reviews.llvm.org/D81175





More information about the llvm-commits mailing list