[PATCH] D81097: [llvm-objcopy] Reorder --dump-section before --remove-section for ELF.

[Sameer Arora via Phabricator via llvm-commits]

sameerarora101 marked 2 inline comments as done.
sameerarora101 added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/ELF/dump-before-add-remove.test:11
+# RUN: not llvm-objcopy --dump-section .test3=%t3.txt --add-section .test3=%t1.txt %t %t4 2>&1 | \
+# RUN:     FileCheck %s --check-prefix=NODUMP -DINPUT=%t -DSECTION=.test3
+
----------------
alexshap wrote:
> sameerarora101 wrote:
> > MaskRay wrote:
> > > alexshap wrote:
> > > > nit: it looks like it's the only place where these macros (INPUT, SECTION) are used. In this case we don't really need them, simply use the corresponding values directly (on the line 37)
> > > I think we typically place CHECK lines before the tests. Some earlier tests do not follow the convention, but newer tests can.
> > I was able to do this for SECTION but it seems I still need to pass in the INPUT macro with FileCheck (it explicitly prints `%t` otherwise). Is that fine?
> >I was able to do this for SECTION but it seems I still need to pass in the INPUT macro with FileCheck (it explicitly prints %t otherwise). Is that fine?
> I would remove -DSECTION - it would slightly trim down the command line / look simpler
> 
Yup, removed it in the new revision, thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81097/new/

https://reviews.llvm.org/D81097