[PATCH] D80370: [CodeGen] Ensure callers of CreateStackTemporary use sensible alignments

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 4 09:53:12 PDT 2020


efriedma added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeTypes.cpp:893
+  SDValue StackPtr =
+      DAG.CreateStackTemporary(Op.getValueType().getStoreSize(), Align);
   // Emit a store to the stack slot.
----------------
You changed the alignment of the stack temporary... but you still didn't change the alignment of the load or the store to that stack slot, so they're still wrong.  (Same applies to other changes.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80370/new/

https://reviews.llvm.org/D80370





More information about the llvm-commits mailing list