[PATCH] D81165: [DebugInfo] Refactor how unrecoverable debug line parsing errors work

[James Henderson via Phabricator via llvm-commits]

jhenderson created this revision.
jhenderson added reviewers: dblaikie, JDevlieghere, aprantl, ikudrin, MaskRay, probinson, labath.
Herald added subscribers: cmtice, hiraditya.
Herald added a project: LLVM.

Previously, unrecoverable errors were passed back to the debug line parse() caller, who would then pass the error to a callback. This meant that such errors were inconsistently printed in the output between verbose and non-verbose output: for verbose output, they'd be printed after the output (which is printed at the end of the parse() function) whilst non-verbose output was printed later on, after the error callback was run. This patch moves the error callback usage to inside the parse() function.

Depends on D81102 <https://reviews.llvm.org/D81102>.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D81165

Files:
  llvm/include/llvm/DebugInfo/DWARF/DWARFDebugLine.h
  llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp
  llvm/test/tools/llvm-dwarfdump/X86/debug_line_invalid.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D81165.268471.patch
Type: text/x-patch
Size: 4696 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200604/8c6bb5fa/attachment.bin>