[PATCH] D81123: [llvm-objcopy] Reorder --dump-section for MachO. Fixes PR44283

Thu Jun 4 07:04:20 PDT 2020

sameerarora101 added a comment.

In D81123#2072964 <https://reviews.llvm.org/D81123#2072964>, @jhenderson wrote:

> When I originally filed the bug, this was an issue in ELF too. Could you check the other formats, specifically ELF, but other formats too if they support --dump-section, to make sure they behave the right way, please? If not, they'll want fixing, but you can do that in a separate patch (but the bug isn't resolved until it works for all formats).

Yup, I have a patch for ELF at D81097 <https://reviews.llvm.org/D81097>
For COFF: `DumpSection` options isn't supported and
for wasm: `DumpSection` is already being performed before add/remove.

So I think D81123 <https://reviews.llvm.org/D81123> (MachO) and D81097 <https://reviews.llvm.org/D81097> (ELF) together fix the bug?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81123/new/

https://reviews.llvm.org/D81123