[PATCH] D71943: AMDGPU/GlobalISel: Add stub reg-bank aware combiner pass

Mikael Holmén via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 4 07:04:16 PDT 2020


uabelho added a comment.

Hi!

With gcc 7.4, the following warning pops up with this patch:

  [32/115] Building CXX object lib/Target/AMDGPU/CMakeFiles/LLVMAMDGPUCodeGen.dir/AMDGPURegBankCombiner.cpp.o
  In file included from ../lib/Target/AMDGPU/AMDGPURegBankCombiner.cpp:39:0:
  lib/Target/AMDGPU/AMDGPUGenRegBankGICombiner.inc:65:6: warning: 'bool {anonymous}::AMDGPUGenRegBankCombinerHelper::isRuleDisabled(unsigned int) const' defined but not used [-Wunused-function]
   bool AMDGPUGenRegBankCombinerHelper::isRuleDisabled(unsigned RuleID) const {
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  [68/115] Building CXX object lib/Target/AMDGPU/CMakeFiles/LLVMAMDGPUCodeGen.dir/AMDGPUInstructionSelector.cpp.o
  ../lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp: In member function 'bool llvm::AMDGPUInstructionSelector::isVCC(llvm::Register, const llvm::MachineRegisterInfo&) const':
  ../lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp:83:0: note: -Wmisleading-indentation is disabled from this point onwards, since column-tracking was disabled due to the size of the code/headers
     auto &RegClassOrBank = MRI.getRegClassOrRegBank(Reg);
   


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71943/new/

https://reviews.llvm.org/D71943





More information about the llvm-commits mailing list