[PATCH] D80838: [llvm-ar] Add more tests for errors in opening archives

Sameer Arora via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 4 06:31:26 PDT 2020


sameerarora101 marked an inline comment as done.
sameerarora101 added inline comments.


================
Comment at: llvm/test/tools/llvm-ar/error-opening-archive.test:1
+# UNSUPPORTED: system-windows
+
----------------
jhenderson wrote:
> Rather than making all cases unsupported on Windows, I think it would be preferable to split this test into two, with the permission bit in its own test. You should also add a comment to that case saying why it is unsupported on Windows.
On it


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80838/new/

https://reviews.llvm.org/D80838





More information about the llvm-commits mailing list