[PATCH] D80924: [CostModel] Use MaybeAlign in getMemoryOpCost

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 4 03:13:15 PDT 2020


samparker added a comment.

Looking again at the backends, it looks like a very involved task to migrate to Align - particularly because getMaskedMemoryOpCost still uses an unsigned value. So I'd still like to get this patch in for consistency, without having to make large changes to several of the backends (of which I'm not even sure what I'd need to do). As it stands, I assume there's some implicit casting going so these base implementations aren't even receiving an Align object in most cases.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80924/new/

https://reviews.llvm.org/D80924





More information about the llvm-commits mailing list