[PATCH] D78005: [yaml2obj] - Reimplement how tool calculates memory sizes of segments.

Thu Jun 4 01:34:56 PDT 2020

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM.

================
Comment at: llvm/test/tools/yaml2obj/ELF/program-header-nobits.yaml:188-189
+## This segment includes the first section only.
+# NOOFFSET-NEXT: LOAD 0x000000 0x0000000200000000 0x0000000200000000 0x0001c8 0x0001c9
+# OFFSET-NEXT:   LOAD 0x000158 0x0000000200000158 0x0000000200000158 0x000070 0x000071
+
----------------
Just to make sure I'm clear - the file space in these last cases is due to the file header and program header table? It might be worth mentioning this somewhere in the comments.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78005/new/

https://reviews.llvm.org/D78005