[PATCH] D81110: [Support] Move color handling from raw_fd_ostream to raw_ostream

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 3 23:02:11 PDT 2020


MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/unittests/Support/raw_ostream_test.cpp:368
+#ifdef LLVM_ON_UNIX
+    EXPECT_EQ("\x1B[0;33m", Sos.str());
+#endif
----------------
It seems that you can call `sys::Process:UseAnsiEscapeCodes(true)` to use ANSI escape code on Windows. You can then drop the `#ifdef`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81110/new/

https://reviews.llvm.org/D81110





More information about the llvm-commits mailing list