[llvm] c1ea672 - [gcov] Delete XFAIL: host-byteorder-big-endian

Hubert Tong via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 3 20:18:27 PDT 2020


On Wed, Jun 3, 2020 at 10:59 PM Fangrui Song via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

>
> Author: Fangrui Song
> Date: 2020-06-03T19:58:28-07:00
> New Revision: c1ea672ddb919c50118f4031845af6bb9be95454
>
> URL:
> https://github.com/llvm/llvm-project/commit/c1ea672ddb919c50118f4031845af6bb9be95454
> DIFF:
> https://github.com/llvm/llvm-project/commit/c1ea672ddb919c50118f4031845af6bb9be95454.diff
>
> LOG: [gcov] Delete XFAIL: host-byteorder-big-endian
>
> Add two to function-numbering.ll and exit-block.ll
>
> Added:
>
>
> Modified:
>     llvm/test/Transforms/GCOVProfiling/exit-block.ll
>     llvm/test/Transforms/GCOVProfiling/function-numbering.ll
>     llvm/test/Transforms/SampleProfile/gcc-simple.ll
>     llvm/test/Transforms/SampleProfile/indirect-call-gcc.ll
>     llvm/test/tools/llvm-cov/gcov-4.7.c
>     llvm/test/tools/llvm-cov/gcov-8.c
>     llvm/test/tools/llvm-cov/gcov-9.c
>     llvm/test/tools/llvm-profdata/gcc-gcov-sample-profile.test
>
> Removed:
>
>
>
>
> ################################################################################
> diff  --git a/llvm/test/Transforms/GCOVProfiling/exit-block.ll
> b/llvm/test/Transforms/GCOVProfiling/exit-block.ll
> index 202479e72e0c..5ab3dcc9f499 100644
> --- a/llvm/test/Transforms/GCOVProfiling/exit-block.ll
> +++ b/llvm/test/Transforms/GCOVProfiling/exit-block.ll
> @@ -2,6 +2,7 @@
>  ; RUN: rm -rf %t && mkdir -p %t
>  ; RUN: echo '!19 = !{!"%/t/exit-block.ll", !0}' > %t/1
>  ; RUN: cat %s %t/1 > %t/2
> +; XFAIL: host-byteorder-big-endian
>
>  ; By default, the exit block is the second.
>  ; RUN: opt -insert-gcov-profiling -disable-output %t/2
>
> diff  --git a/llvm/test/Transforms/GCOVProfiling/function-numbering.ll
> b/llvm/test/Transforms/GCOVProfiling/function-numbering.ll
> index 973b29f590c4..533bb0a38f7c 100644
> --- a/llvm/test/Transforms/GCOVProfiling/function-numbering.ll
> +++ b/llvm/test/Transforms/GCOVProfiling/function-numbering.ll
> @@ -1,5 +1,6 @@
>  ; Test that GCOV instrumentation numbers functions correctly when some
>  ; functions aren't emitted.
> +; XFAIL: host-byteorder-big-endian
>
>  ; Inject metadata to set the .gcno file location
>  ; RUN: rm -rf %t && mkdir -p %t
>
> diff  --git a/llvm/test/Transforms/SampleProfile/gcc-simple.ll
> b/llvm/test/Transforms/SampleProfile/gcc-simple.ll
> index f778124c2200..71ff19ff1f48 100644
> --- a/llvm/test/Transforms/SampleProfile/gcc-simple.ll
> +++ b/llvm/test/Transforms/SampleProfile/gcc-simple.ll
> @@ -1,6 +1,6 @@
>  ; RUN: opt < %s -sample-profile
> -sample-profile-file=%S/Inputs/gcc-simple.afdo -S | FileCheck %s
>  ; RUN: opt < %s -passes=sample-profile
> -sample-profile-file=%S/Inputs/gcc-simple.afdo -S | FileCheck %s
> -; XFAIL: host-byteorder-big-endian
> +;
>  ; Original code:
>  ;
>  ; #include <stdlib.h>
>
> diff  --git a/llvm/test/Transforms/SampleProfile/indirect-call-gcc.ll
> b/llvm/test/Transforms/SampleProfile/indirect-call-gcc.ll
> index 5298fab44ab1..a9b3eaacff7b 100644
> --- a/llvm/test/Transforms/SampleProfile/indirect-call-gcc.ll
> +++ b/llvm/test/Transforms/SampleProfile/indirect-call-gcc.ll
> @@ -4,7 +4,6 @@
>  ; format profile.
>  ; It is expected to fail on certain architectures as gcc profile reader
> does
>  ; not work.
>
The comments should be updated too.


> -; XFAIL: host-byteorder-big-endian
>
>  define void @test(void ()*) #0 !dbg !3 {
>    %2 = alloca void ()*
>
> diff  --git a/llvm/test/tools/llvm-cov/gcov-4.7.c
> b/llvm/test/tools/llvm-cov/gcov-4.7.c
> index ab08883bde7e..594382bf2900 100644
> --- a/llvm/test/tools/llvm-cov/gcov-4.7.c
> +++ b/llvm/test/tools/llvm-cov/gcov-4.7.c
> @@ -33,5 +33,3 @@ int main() {                                      //
> GCOV:      #####: [[@LINE]]
>  // HEADER-NEXT:  -:    0:Runs:1{{$}}
>  // HEADER-NEXT:  -:    0:Programs:1
>  // HEADER-NEXT:  -:    1:/// Test that llvm-cov
> -
> -// XFAIL: host-byteorder-big-endian
>
> diff  --git a/llvm/test/tools/llvm-cov/gcov-8.c
> b/llvm/test/tools/llvm-cov/gcov-8.c
> index f8cdd18f99bd..4ac9cd671fe2 100644
> --- a/llvm/test/tools/llvm-cov/gcov-8.c
> +++ b/llvm/test/tools/llvm-cov/gcov-8.c
> @@ -33,5 +33,3 @@ int main() {                                      //
> GCOV:      1: [[@LINE]]:int
>  // HEADER-NEXT:  -:    0:Runs:1{{$}}
>  // HEADER-NEXT:  -:    0:Programs:1
>  // HEADER-NEXT:  -:    1:/// Test that llvm-cov
> -
> -// XFAIL: host-byteorder-big-endian
>
> diff  --git a/llvm/test/tools/llvm-cov/gcov-9.c
> b/llvm/test/tools/llvm-cov/gcov-9.c
> index 6e631cb078cf..db6190ad5fbb 100644
> --- a/llvm/test/tools/llvm-cov/gcov-9.c
> +++ b/llvm/test/tools/llvm-cov/gcov-9.c
> @@ -32,5 +32,3 @@ int main() {                                      //
> GCOV:      1: [[@LINE]]:int
>  // HEADER-NEXT:  -:    0:Data:gcov-9.gcda
>  // HEADER-NEXT:  -:    0:Runs:1{{$}}
>  // HEADER-NEXT:  -:    1:/// Test that llvm-cov
> -
> -// XFAIL: host-byteorder-big-endian
>
> diff  --git a/llvm/test/tools/llvm-profdata/gcc-gcov-sample-profile.test
> b/llvm/test/tools/llvm-profdata/gcc-gcov-sample-profile.test
> index 42ae5d233092..5f6c2a221eb2 100644
> --- a/llvm/test/tools/llvm-profdata/gcc-gcov-sample-profile.test
> +++ b/llvm/test/tools/llvm-profdata/gcc-gcov-sample-profile.test
> @@ -1,8 +1,6 @@
>  The input gcov file has been generated on a little endian machine. Expect
>  failures on big endian systems.
>
Same here. Maybe check all of the files?


>
> -XFAIL: host-byteorder-big-endian
> -
>  Tests for sample profiles encoded in GCC's gcov format.
>
>  1- Show all functions. This profile has a single main() function with
> several
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200603/bd51c4f1/attachment.html>


More information about the llvm-commits mailing list