[PATCH] D81113: lld: add basic static library search

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 3 16:35:27 PDT 2020


int3 accepted this revision.
int3 added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!



================
Comment at: lld/test/MachO/static-link.s:25-30
+# CHECK: SYMBOL TABLE:
+# CHECK: {{0+}}[[ADDR:[0-9a-f]+]] g     O __TEXT,__cstring _goodbye_world
+
+# CHECK: Disassembly of section __TEXT,__text
+# CHECK-LABEL: <_main>:
+# CHECK: leaq {{.*}}(%rip), %rsi   # [[ADDR]] <_goodbye_world>
----------------
nit: we usually put these right after their respective FileCheck invocation line (so after line 11 in this file)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81113/new/

https://reviews.llvm.org/D81113





More information about the llvm-commits mailing list