[PATCH] D80937: Introduce a "gc-live" bundle for the gc arguments of a statepoint

[Philip Reames via Phabricator via llvm-commits]

reames marked an inline comment as done.
reames added inline comments.


================
Comment at: llvm/lib/IR/Verifier.cpp:4760
+             "gc.relocate: statepoint derived index out of bounds", Call);
+    } else {
+      Assert(0 <= BaseIndex && BaseIndex < (int)StatepointCall.arg_size(),
----------------
dantrushin wrote:
> BTW, I find this inconsistent with definition of GCRelocateInst.
> Its base/derived ptr indices are unsigned and one can successfully create gc.relocate with index in [0, 2^32-1] range.
> Then verifier suddenly shrinks allowed range into [0, 2^31-1].
> Do you really want enforce index be positive signed int? Why not just require it is smaller (unsigned) than Inputs.size()?
Addressed in a separate commit.

commit ff529e0f2792e1383a602e4b8a466337fd0c2926


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80937/new/

https://reviews.llvm.org/D80937