[PATCH] D81097: [llvm-objcopy] Reorder --dump-section before --remove-section for ELF. Fixes PR44283

Sameer Arora via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 3 12:05:43 PDT 2020


sameerarora101 marked 2 inline comments as done.
sameerarora101 added inline comments.


================
Comment at: llvm/tools/llvm-objcopy/ELF/ELFObjcopy.cpp:623
+  for (const auto &Flag : Config.DumpSection) {
+    std::pair<StringRef, StringRef> SecPair = Flag.split("=");
+    StringRef SecName = SecPair.first;
----------------
alexshap wrote:
>   StringRef SectionName;
>   StringRef FileName;
>   std::tie(SectionName, FileName) = Flag.split('=');
Got it, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81097/new/

https://reviews.llvm.org/D81097





More information about the llvm-commits mailing list