[PATCH] D81102: [DebugInfo] Improve new line printing in debug line verbose output

[James Henderson via Phabricator via llvm-commits]

jhenderson created this revision.
jhenderson added reviewers: aprantl, labath, dblaikie, ikudrin, probinson, MaskRay, JDevlieghere.
Herald added subscribers: cmtice, hiraditya.
Herald added a project: LLVM.

The new line printing for debug line verbose output was inconsistent. For new rows in the matrix, a blank line followed, whilst the DW_LNS_copy opcode actually resulted in two blank lines. There was also potential inconsistency in the blank lines at the end of the table. This patch resolves these issues - no blank lines appear in the output except for a single line after the prologue and at table end to separate it from any subsquent table.

Also add a unit test for verbose output to test the fine details of new line placement and other aspects of verbose output.

Depends on D80989 <https://reviews.llvm.org/D80989>.
Also depends on D80797 <https://reviews.llvm.org/D80797>.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D81102

Files:
  llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp
  llvm/test/tools/llvm-dwarfdump/X86/debug_line_invalid.test
  llvm/test/tools/llvm-dwarfdump/X86/verbose.test
  llvm/unittests/DebugInfo/DWARF/DWARFDebugLineTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D81102.268205.patch
Type: text/x-patch
Size: 13308 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200603/c36dd326/attachment.bin>