[PATCH] D80989: [DebugInfo] Print non-verbose output at some point as verbose output

[James Henderson via Phabricator via llvm-commits]

jhenderson updated this revision to Diff 268178.
jhenderson retitled this revision from "[DebugInfo] Make verbose line output appear at same point as non-verbose" to "[DebugInfo] Print non-verbose output at some point as verbose output".
jhenderson edited the summary of this revision.
jhenderson added a parent revision: D80874: [llvm-dwarfdump] Add a table header for -debug-line -verbose output.
jhenderson added a comment.
This revision is now accepted and ready to land.

Completely change approach by changing the parsing API to take both a stream and verbose boolean - the presence of the stream indicates output should be emitted, whilst the boolean indicates whether verbose output should be emitted. This means that verbose and non-verbose output will be emitted at the same time. This patch also rebases the change on top of D80874 <https://reviews.llvm.org/D80874>, but a side-effect is that non-verbose output now includes a header if there are any opcodes whereas before it only included the column headers for a table where there are one or more rows. There is unlikely to be much difference between the two.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80989/new/

https://reviews.llvm.org/D80989

Files:
  llvm/include/llvm/DebugInfo/DWARF/DWARFDebugLine.h
  llvm/lib/DebugInfo/DWARF/DWARFContext.cpp
  llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp
  llvm/test/tools/llvm-dwarfdump/X86/debug_line_dwarf64_large_table.s
  llvm/test/tools/llvm-dwarfdump/X86/debug_line_invalid.test
  llvm/test/tools/llvm-dwarfdump/X86/verbose.test
  llvm/unittests/DebugInfo/DWARF/DWARFDebugLineTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D80989.268178.patch
Type: text/x-patch
Size: 26913 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200603/40e71f0b/attachment-0001.bin>