[PATCH] D80803: [llvm-dwarfdump] Flush output before warning and errors are reported

Wed Jun 3 03:48:20 PDT 2020

labath added a comment.

In D80803#2069014 <https://reviews.llvm.org/D80803#2069014>, @JDevlieghere wrote:

> In D80803#2068152 <https://reviews.llvm.org/D80803#2068152>, @labath wrote:
>
> > So, combining stdout and stderr is an issue that a lot of people considered important, and indeed there are a lot of tools out there which get it "right".
>
>
> I hope I didn't give the impression that I don't think it's important. I think it's really useful to have `stdout` and `stderr` for exactly the reason that James mentioned. Everything I said was weighing those benefits agains us having to maintain flushes in `dwarfdump`.

Cool. Thanks for clearing that up.

In D80803#2070721 <https://reviews.llvm.org/D80803#2070721>, @jhenderson wrote:

> I'm going to focus on getting my other queued-up patches up for review before I start looking at option 3. If people are happy for this to go in, it will help with me landing the other patches I have planned, but probably isn't actually required and I can probably workaround things to some extent, so can wait if that's the preferred approach. Just let me know!

Since I started this whole thing, I felt like I should also chip in a bit. I've created D81078 <https://reviews.llvm.org/D81078> to do the ToolOutputFile refactor. The changes are fairly straight-forward, and they don't break any of the in-tree tests. I have no idea whether they will break some strange out-of-tree use case (I feel it's relatively safe though the potential for it is definitely there...), but I suppose there's only one way to find that out...

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80803/new/

https://reviews.llvm.org/D80803