[PATCH] D81022: [Attributor] Split the Attributor::run() into multiple functions.

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

Nice cleanup. I basically have only comments on the documentation.



================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:1220
+  /// where scheduled for a update.
+  void runScheduler();
+
----------------
I find the name of this not convincing. Maybe, `runTillFixpoint` or something along those lines?
The documentation should also be a bit more descriptive, e.g., in case of a time out of what? At the same time we don't need to talk about the dep graph but could just say, "on attributes that haven't reached a known valid fixpoint yet".


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81022/new/

https://reviews.llvm.org/D81022