[PATCH] D80859: [lld-macho] Ensure __bss sections we output have file offset of zero

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 2 15:56:28 PDT 2020


int3 added a comment.

> If no tool enforces this, then maybe this is unnecessary?

If we don't have an offset of zero, then it appears that whatever bytes at that non-zero offset get copied into `__bss`. Unlike `__PAGEZERO`, which is a segment, there's no way to say that a section has a non-zero vmsize but a zero filesize: there's just a single `size` field. So I guess I should've said it's necessary if we don't want to actually allocate disk space for the zero bytes in our binary.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80859/new/

https://reviews.llvm.org/D80859





More information about the llvm-commits mailing list