[PATCH] D80953: [AIX] asm output: use character literals in byte lists for strings

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 2 15:56:27 PDT 2020


hubert.reinterpretcast added a comment.

In D80953#2069244 <https://reviews.llvm.org/D80953#2069244>, @daltenty wrote:

> I'm sure this may have been considered, but


Yes, the patch description says consideration was given towards "having strings kept as logical units on the same line". This is beneficial for the purposes of being able to grep even when sequences mix "printable" and "non-printable" characters. For example, the UTF-8 code unit sequence for e with acute would likely end up on a line of its own if the alternative you mention is used. For a program with strings in French, I imagine that could be rather annoying.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80953/new/

https://reviews.llvm.org/D80953





More information about the llvm-commits mailing list